Skip to content

UnicodeEncodeError on source files containing non-ascii characters #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spg wants to merge 2 commits into from
Closed

UnicodeEncodeError on source files containing non-ascii characters #4074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e717d9
getstatementrange_ast() causes UnicodeEncodeError on files containing…
spg Oct 3, 2018
f818e2a
PY2 switch
spg Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/_pytest/_code/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,10 @@ def get_statement_startend2(lineno, node):

def getstatementrange_ast(lineno, source, assertion=False, astnode=None):
if astnode is None:
content = str(source)
if six.PY2:
content = unicode(source)
Copy link
Member

@nicoddemus nicoddemus Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this still might fail, because unicode will try to use the ascii codec to decode the bytestream (see py27 failure). Not sure if by this point getstatementrange_ast shouldn't already be a unicode stream actually. 🤔

else:
content = str(source)
astnode = compile(content, "source", "exec", 1024) # 1024 for AST

start, end = get_statement_startend2(lineno, astnode)
Expand Down