tests: clarify/document/harden acceptance tests#4123
tests: clarify/document/harden acceptance tests#4123blueyed merged 2 commits intopytest-dev:masterfrom
Conversation
testing/acceptance_test.py
Outdated
| # └── test_bar.py | ||
|
|
||
| def join_pythonpath(*dirs): | ||
| def append_pythonpath(*dirs): |
There was a problem hiding this comment.
This is actually prepending dirs to the PYTHONPATH right?
testing/acceptance_test.py
Outdated
| # └── test_world.py | ||
|
|
||
| def join_pythonpath(*dirs): | ||
| def append_pythonpath(*dirs): |
There was a problem hiding this comment.
This is actually prepending dirs to the PYTHONPATH right?
There was a problem hiding this comment.
True (also above). Will rename it.
| "*lib/foo/bar/test_bar.py::test_bar*PASSED*", | ||
| "*lib/foo/bar/test_bar.py::test_other*PASSED*", | ||
| "*lib/foo/bar/test_bar.py::test_bar PASSED*", | ||
| "*lib/foo/bar/test_bar.py::test_other PASSED*", |
There was a problem hiding this comment.
With #4108 this will change to:
lib/foo/bar/test_bar.py::test_bar <- local/lib/foo/bar/test_bar.py PASSED [ 50%]
lib/foo/bar/test_bar.py::test_other <- local/lib/foo/bar/test_bar.py PASSED [100%]
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
great work at finding those enhancement points
please take a look at integrating the features of monkey patch more neatly
Codecov Report
@@ Coverage Diff @@
## master #4123 +/- ##
==========================================
+ Coverage 94.44% 94.49% +0.04%
==========================================
Files 109 109
Lines 23813 23803 -10
Branches 2349 2346 -3
==========================================
+ Hits 22491 22493 +2
+ Misses 1010 1003 -7
+ Partials 312 307 -5
Continue to review full report at Codecov.
|
|
Codecov diff report for reference: https://codecov.io/gh/pytest-dev/pytest/commit/6bf4692c7d8100b19dc0178764398edbd7803701 |
4 participants
Followup of / replaces #4106.