fix #4135 - handle symlinks in tmp path cleanup

[RonnyPfannschmidt]

.

[coveralls]

Coverage increased (+0.01%) to 93.772% when pulling ced62f3 on RonnyPfannschmidt:pathlib-cleanup-symlink-is-fine into 0be84cd on pytest-dev:features.

[nicoddemus]

I noticed the test would fail on Windows, decided to improve how symlinks are handled so it works when running on Windows with proper privileges. 👍

[codecov]

Codecov Report

Merging #4148 into features will increase coverage by 0.04%.
The diff coverage is 89.47%.

@@             Coverage Diff              @@
##           features    #4148      +/-   ##
============================================
+ Coverage     94.45%   94.49%   +0.04%     
============================================
  Files           109      109              
  Lines         24169    24185      +16     
  Branches       2381     2383       +2     
============================================
+ Hits          22829    22854      +25     
+ Misses         1021     1017       -4     
+ Partials        319      314       -5

Flag	Coverage Δ
#linux	94.33% <78.94%> (+0.03%)	⬆️
#nobyte	0% <0%> (ø)	⬆️
#numpy	28.2% <0%> (+0.04%)	⬆️
#pexpect	0% <0%> (ø)	⬆️
#py27	92.64% <89.47%> (+0.04%)	⬆️
#py34	92.06% <78.94%> (+0.02%)	⬆️
#py35	92.08% <78.94%> (+0.02%)	⬆️
#py36	92.64% <78.94%> (+0.03%)	⬆️
#py37	92.28% <78.94%> (+0.02%)	⬆️
#trial	31.29% <0%> (+0.04%)	⬆️
#windows	93.78% <89.47%> (+0.02%)	⬆️
#xdist	18.91% <0%> (ø)	⬆️

Impacted Files	Coverage Δ
src/_pytest/pathlib.py	88.12% <100%> (+0.78%)	⬆️
testing/test_tmpdir.py	98.63% <88.23%> (-1.37%)	⬇️
src/_pytest/terminal.py	91.62% <0%> (+1.74%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be84cd...ced62f3. Read the comment docs.

[RonnyPfannschmidt]

fabulous - its just awesome to have someone fix your patches while you go to sleep 👍