don`t parse compat properties as fixtures#4164
Merged
nicoddemus merged 2 commits intopytest-dev:masterfrom Oct 31, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4164 +/- ##
==========================================
- Coverage 95.87% 95.85% -0.02%
==========================================
Files 109 109
Lines 24626 24610 -16
Branches 2395 2395
==========================================
- Hits 23609 23591 -18
- Misses 721 722 +1
- Partials 296 297 +1
Continue to review full report at Codecov.
|
Member
|
Hi @RonnyPfannschmidt, this seems to be working fine, why is it a RFC? Seems like it gets rid of the warnings about compat-properties during fixture collection quite nicely. 👍 |
Member
Author
|
@nicoddemus mainly because i skipped on tests and the docs |
Member
|
Oh OK, I was under an erroneous definition of what |
Member
Author
|
no, i was ^^ |
This was referenced Oct 18, 2018
cfaa19e to
b55f5eb
Compare
this avoid triggering the warnings when parsing the session node as session plugin
b55f5eb to
da04ff5
Compare
nicoddemus
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2701
its tricky to trigger those warnings under normal circumstances as they happen before pytest hooks into the warnings system
python -W always -m pytest testing/test_tmpdir.py --collectonlycould be used to trigger them for example on the cli