Skip to content

fix test_cleanup_keep for expecting symlinks #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoddemus merged 2 commits into from
Oct 17, 2018
Merged

fix test_cleanup_keep for expecting symlinks #4185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dca8f3
fix test_cleanup_keep for expecting symlinks
RonnyPfannschmidt Oct 17, 2018
56dd7bc
TestNumberedDir: ignore that symlinks arent created on windows
RonnyPfannschmidt Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions testing/test_tmpdir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,10 @@ def test_make(self, tmp_path):
assert d.name.endswith(str(i))

symlink = tmp_path.joinpath(self.PREFIX + "current")
assert symlink.is_symlink()
assert symlink.resolve() == d.resolve()
if symlink.exists():
# unix
assert symlink.is_symlink()
assert symlink.resolve() == d.resolve()

def test_cleanup_lock_create(self, tmp_path):
d = tmp_path.joinpath("test")
Expand Down Expand Up @@ -248,7 +250,7 @@ def _do_cleanup(self, tmp_path):

def test_cleanup_keep(self, tmp_path):
self._do_cleanup(tmp_path)
a, b = tmp_path.iterdir()
a, b = (x for x in tmp_path.iterdir() if not x.is_symlink())
print(a, b)

def test_cleanup_locked(self, tmp_path):
Expand Down