Improve error message when it is not possible to determine a function's signature#4196
Merged
asottile merged 1 commit intopytest-dev:masterfrom Oct 19, 2018
Merged
Conversation
Member
Author
🤣 I just wanted to relax a bit and decided to fix some old issues, and this one appeared on my search. What a coincidence! 😁 |
Codecov Report
@@ Coverage Diff @@
## master #4196 +/- ##
==========================================
+ Coverage 95.81% 95.83% +0.01%
==========================================
Files 109 109
Lines 24231 24343 +112
Branches 2389 2416 +27
==========================================
+ Hits 23216 23328 +112
+ Misses 720 719 -1
- Partials 295 296 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement as it at least indicates which is the problematic function:
Fix #4026