Skip to content

Fix "Plugin already registered" error with symlinks#4214

Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom
blueyed:fix-4174
Oct 23, 2018
Merged

Fix "Plugin already registered" error with symlinks#4214
nicoddemus merged 1 commit intopytest-dev:masterfrom
blueyed:fix-4174

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 22, 2018

Fixes #4174.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just need a changelog entry. 😁

if self._noconftest:
return []

path = path.realpath()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move this down to after the cache check.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #4214 into master will increase coverage by 1.98%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4214      +/-   ##
==========================================
+ Coverage   93.82%   95.81%   +1.98%     
==========================================
  Files         109      109              
  Lines       24286    24296      +10     
  Branches     2392     2395       +3     
==========================================
+ Hits        22787    23279     +492     
+ Misses       1172      721     -451     
+ Partials      327      296      -31
Flag Coverage Δ
#docs 28.5% <16.66%> (?)
#doctesting 28.5% <16.66%> (?)
#linting 28.5% <16.66%> (?)
#linux 95.59% <100%> (+3.32%) ⬆️
#nobyte 91.89% <100%> (?)
#numpy 92.9% <16.66%> (?)
#pexpect 41.26% <16.66%> (?)
#py27 93.95% <100%> (+2.92%) ⬆️
#py34 92.23% <100%> (+0.16%) ⬆️
#py35 92.24% <100%> (?)
#py36 93.9% <100%> (+1.84%) ⬆️
#py37 92.26% <100%> (?)
#trial 92.9% <16.66%> (?)
#windows 94.03% <16.66%> (+3%) ⬆️
#xdist 93.78% <100%> (?)
Impacted Files Coverage Δ
src/_pytest/config/__init__.py 94.93% <100%> (+0.34%) ⬆️
testing/test_conftest.py 99.6% <100%> (ø) ⬆️
testing/code/test_code.py 94.11% <0%> (-1.34%) ⬇️
testing/code/test_source.py 97.02% <0%> (ø) ⬆️
testing/python/fixture.py 99.24% <0%> (+0.1%) ⬆️
src/_pytest/assertion/rewrite.py 95.68% <0%> (+0.16%) ⬆️
testing/deprecated_test.py 100% <0%> (+0.77%) ⬆️
testing/test_parseopt.py 94.65% <0%> (+0.82%) ⬆️
src/_pytest/pytester.py 87.3% <0%> (+0.86%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799b72c...f54b4f2. Read the comment docs.

@blueyed blueyed requested a review from nicoddemus October 23, 2018 19:27
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@nicoddemus nicoddemus merged commit 72d98a7 into pytest-dev:master Oct 23, 2018
@blueyed blueyed deleted the fix-4174 branch October 24, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants