collection: _recurse: skip __pycache__#4250
Merged
nicoddemus merged 1 commit intopytest-dev:featuresfrom Oct 30, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## features #4250 +/- ##
============================================
+ Coverage 95.83% 95.83% +<.01%
============================================
Files 111 111
Lines 24768 24777 +9
Branches 2414 2417 +3
============================================
+ Hits 23737 23746 +9
Misses 734 734
Partials 297 297
Continue to review full report at Codecov.
|
Contributor
Author
|
This improves performance from 10.5s to 8.35s with the 1000-files-test-case. |
nicoddemus
approved these changes
Oct 30, 2018
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken out of #4237.
According to https://codecov.io/gh/pytest-dev/pytest/commit/5850de62f11785ade9c980a9243f07d804d1f976 it should not be covered completely: python's
_recursewas copied from the Session, which might not make sense completely, or would just need some tests for thepytest_ignore_collectcode therein.