Swallow warnings during anonymous compilation of source#4261
Merged
asottile merged 2 commits intopytest-dev:masterfrom Oct 30, 2018
asottile:no_anonymous_source_warning
Merged
Swallow warnings during anonymous compilation of source#4261asottile merged 2 commits intopytest-dev:masterfrom asottile:no_anonymous_source_warning
asottile merged 2 commits intopytest-dev:masterfrom
asottile:no_anonymous_source_warning
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4261 +/- ##
==========================================
- Coverage 95.87% 95.86% -0.01%
==========================================
Files 109 109
Lines 24606 24608 +2
Branches 2394 2394
==========================================
Hits 23591 23591
- Misses 720 721 +1
- Partials 295 296 +1
Continue to review full report at Codecov.
|
nicoddemus
reviewed
Oct 29, 2018
nicoddemus
reviewed
Oct 29, 2018
blueyed
approved these changes
Oct 30, 2018
Contributor
blueyed
left a comment
There was a problem hiding this comment.
Travis finished successfully (https://travis-ci.org/pytest-dev/pytest/builds/447862356) despite the reported (pending) status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4260
For the same reasons as this it's difficult to write a future-proof regression test for this.
Here's what I used locally to verify this though:
before
after