Change RemovedInPytest4Warnings to errors by default#4349
Merged
nicoddemus merged 2 commits intopytest-dev:featuresfrom Nov 13, 2018
Merged
Change RemovedInPytest4Warnings to errors by default#4349nicoddemus merged 2 commits intopytest-dev:featuresfrom
nicoddemus merged 2 commits intopytest-dev:featuresfrom
Conversation
nicoddemus
force-pushed
the
pytest4-warnings-as-errors
branch
from
8dd5ca7 to
748ac78
Compare
Codecov Report
@@ Coverage Diff @@
## features #4349 +/- ##
============================================
+ Coverage 95.84% 95.84% +<.01%
============================================
Files 111 111
Lines 24928 24954 +26
Branches 2438 2440 +2
============================================
+ Hits 23892 23918 +26
Misses 737 737
Partials 299 299
Continue to review full report at Codecov.
|
nicoddemus
force-pushed
the
pytest4-warnings-as-errors
branch
3 times, most recently
from
a498f80 to
d9d9ec9
Compare
To keep existing tests which emit RemovedInPytest4Warnings running, decided to go with a command line option because: * Is harder to integrate an ini option with tests which already use an ini file * It also marks tests which need to be removed/updated in 4.1, when RemovedInPytest4Warning and related functionality are removed. Fix pytest-dev#3737
nicoddemus
force-pushed
the
pytest4-warnings-as-errors
branch
from
d9d9ec9 to
dc20ded
Compare
Otherwise the tests will use tox's env cache which makes them flaky
Member
Author
|
Ready for review! |
RonnyPfannschmidt
approved these changes
Nov 12, 2018
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
the approach with the extra argument creates a little headache for me but on the flip side its a nice tool for various indications as you noted
practicality beats purity 👍
| """ | ||
| ) | ||
|
|
||
| # customize cache directory so we don't use the tox's cache directory, which makes tests in this module flaky |
Member
There was a problem hiding this comment.
we ought to make this more general as i believe there are other bits that can and will affect that
its ok as a followup tho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To keep existing tests which emit RemovedInPytest4Warnings running, decided
to go with a command line option because:
RemovedInPytest4Warning and related functionality are removed.
Fix #3737