Deprecate the 'message' parameter of pytest.raises#4539
Merged
nicoddemus merged 1 commit intopytest-dev:featuresfrom Dec 13, 2018
Merged
Deprecate the 'message' parameter of pytest.raises#4539nicoddemus merged 1 commit intopytest-dev:featuresfrom
nicoddemus merged 1 commit intopytest-dev:featuresfrom
Conversation
asottile
approved these changes
Dec 12, 2018
Member
|
ah doctests, I always forget those too ;) |
RonnyPfannschmidt
requested changes
Dec 12, 2018
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
that one should have been match, but its a good extra example that this is the right path forward
we mess up ourselves as is
nicoddemus
force-pushed
the
deprecate-pytest-raises-message
branch
from
9741a8c to
18fd43e
Compare
Member
Author
|
Hmmm better to remove the |
nicoddemus
force-pushed
the
deprecate-pytest-raises-message
branch
from
18fd43e to
5b83417
Compare
Member
Author
|
OK, ready. Also revamped the docs for |
Codecov Report
@@ Coverage Diff @@
## features #4539 +/- ##
============================================
- Coverage 95.77% 95.76% -0.02%
============================================
Files 111 111
Lines 24954 24961 +7
Branches 2462 2462
============================================
+ Hits 23900 23904 +4
Misses 747 747
- Partials 307 310 +3
Continue to review full report at Codecov.
|
RonnyPfannschmidt
approved these changes
Dec 13, 2018
|
Thanks for making this happen! |
4 tasks
gene1wood
added a commit
to gene1wood/pytest
that referenced
this pull request
Sep 9, 2019
Remove reference to the `message` argument in the docs as it was deprecated in pytest-dev#4539
felixbiessmann
pushed a commit
to felixbiessmann/datawig
that referenced
this pull request
Nov 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3974