Travis: run pytest --help for (stable) TTY coverage#4884
Closed
blueyed wants to merge 4 commits intopytest-dev:masterfrom
Closed
Travis: run pytest --help for (stable) TTY coverage#4884blueyed wants to merge 4 commits intopytest-dev:masterfrom
pytest --help for (stable) TTY coverage#4884blueyed wants to merge 4 commits intopytest-dev:masterfrom
Conversation
According to https://codecov.io/gh/pytest-dev/pytest/pull/4881/changes the "isatty" branches in _pytest/terminal.py are flaky. This tries to fix it.
Codecov Report
@@ Coverage Diff @@
## master #4884 +/- ##
==========================================
+ Coverage 94.47% 94.53% +0.06%
==========================================
Files 113 113
Lines 25173 25173
Branches 2499 2499
==========================================
+ Hits 23782 23798 +16
+ Misses 1060 1048 -12
+ Partials 331 327 -4
Continue to review full report at Codecov.
|
Contributor
Author
|
Also increased/covered without. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://codecov.io/gh/pytest-dev/pytest/pull/4881/changes
the "isatty" branches in _pytest/terminal.py are flaky.
This tries to fix it.
Maybe running it in a subprocess would also help, but it might be more about the outer term in the first place.
Travis should behave as a TTY AFAIK.