Optimize TracebackEntry.ishidden#4919
Merged
blueyed merged 1 commit intopytest-dev:featuresfrom Mar 14, 2019
Merged
Conversation
The expected behavior is that there is no "__tracebackhide__" attribute, so use `getattr` instead of multiple try/except.
Codecov Report
@@ Coverage Diff @@
## features #4919 +/- ##
============================================
- Coverage 95.84% 95.84% -0.01%
============================================
Files 113 113
Lines 25218 25213 -5
Branches 2490 2490
============================================
- Hits 24171 24166 -5
Misses 734 734
Partials 313 313
Continue to review full report at Codecov.
|
nicoddemus
reviewed
Mar 14, 2019
nicoddemus
approved these changes
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected behavior is that there is no "
__tracebackhide__" attribute,so use
getattrinstead of multiple try/except.