tests: fix test_trace_after_runpytest#5245
Merged
nicoddemus merged 1 commit intopytest-dev:featuresfrom May 23, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## features #5245 +/- ##
============================================
+ Coverage 92.1% 93.27% +1.17%
============================================
Files 115 115
Lines 26159 26156 -3
Branches 2578 2578
============================================
+ Hits 24093 24397 +304
+ Misses 1742 1445 -297
+ Partials 324 314 -10
Continue to review full report at Codecov.
|
It was not really testing what it was supposed to test (e.g. the inner test was not run in the first place).
blueyed
force-pushed
the
fix-test_trace_after_runpytest
branch
from
bc786b2 to
dda2193
Compare
nicoddemus
reviewed
May 23, 2019
| def test_inner(): | ||
| assert len(pytestPDB._saved) == 2 | ||
| print() | ||
| print("test_inner_" + "end") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not really testing what it was supposed to test (e.g. the inner
test was not run in the first place).