[4.6] Merge pull request #5373 from asottile/revert_all_handling

[asottile]

Revert unrolling of all()

I had to manually resolve conflicts and apply the patch to visit_Call_legacy as well

[nicoddemus]

Great work!

[blueyed]

Thanks!

Is the plan then to have this not for 4.6 (also later)? Would be good/ok I think.

[asottile]

Thanks!

Is the plan then to have this not for 4.6 (also later)? Would be good/ok I think.

yeah I don't think we'll try and reintroduce this feature on the 4.6 branch

[nicoddemus]

Agreed. 👍

[codecov]

Codecov Report

Merging #5376 into 4.6-maintenance will increase coverage by 51.38%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           4.6-maintenance    #5376       +/-   ##
====================================================
+ Coverage            39.16%   90.55%   +51.38%     
====================================================
  Files                  115      115               
  Lines                26399    26362       -37     
  Branches              2468     2603      +135     
====================================================
+ Hits                 10339    23871    +13532     
+ Misses               15407     2163    -13244     
+ Partials               653      328      -325

Impacted Files	Coverage Δ
src/_pytest/assertion/rewrite.py	95.77% <ø> (+17.9%)	⬆️
testing/test_assertrewrite.py	84.06% <ø> (+69.09%)	⬆️
src/_pytest/unittest.py	94.21% <0%> (+1.57%)	⬆️
testing/test_warnings.py	26.77% <0%> (+2.73%)	⬆️
src/_pytest/warning_types.py	100% <0%> (+5%)	⬆️
src/_pytest/debugging.py	90.25% <0%> (+5.12%)	⬆️
testing/logging/test_reporting.py	21.03% <0%> (+8.62%)	⬆️
src/_pytest/outcomes.py	97.33% <0%> (+13.33%)	⬆️
src/_pytest/warnings.py	88.88% <0%> (+17.28%)	⬆️
... and 92 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114dba5...12bf458. Read the comment docs.

[blueyed]

will increase coverage by 51.38%.

\o/ ;)

[asottile]

@nicoddemus did you want to run this release?

[nicoddemus]

Not in particular, go ahead if you want. Otherwise I will do it in 3 hours or so when I get home. 👍

[asottile]

alright I'll prep it, feel free to take it the rest of the way out if I don't get to it in time :)

[nicoddemus]

Thanks, will do! 👍

[asottile]

here's 4.6.2: #5379