re-enable pypy3#5437
Merged
asottile merged 2 commits intopytest-dev:masterfrom Jun 11, 2019
asottile:reenable_pypy3
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5437 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 114 114
Lines 25502 25502
Branches 2479 2479
=======================================
Hits 24479 24479
Misses 717 717
Partials 306 306Continue to review full report at Codecov.
|
asottile
requested review from
blueyed and
nicoddemus
and removed request for
blueyed
blueyed
approved these changes
Jun 11, 2019
Member
|
Sorry for the delay, great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pushed a workaround into importlib-metadata which avoids the call causing the ResourceWarning
https://gitlab.com/python-devs/importlib_metadata/merge_requests/75
Resolves #5317