Add exception to value alias on ExceptionInfo by graingert · Pull Request #5541 · pytest-dev/pytest

graingert · 2019-07-03T09:15:49Z

For easier compatibility with unittest pytest-dev/unittest2pytest#36

RonnyPfannschmidt · 2019-07-03T10:22:59Z

imho this should also issue a warning so users can fix their code up

graingert · 2019-07-03T10:38:01Z

@RonnyPfannschmidt totally agree, what warning should it be? Deprecation warning feels fundamentally wrong here

nicoddemus

Thanks @graingert!

See my suggestion about which warning and message to use.

Please target features and add a CHANGELOG entry. 👍

src/_pytest/_code/code.py

For easier compatibility with unittest pytest-dev/unittest2pytest#36 Co-Authored-By: Bruno Oliveira <nicoddemus@gmail.com>

changelog/5541.feature.rst

nicoddemus

Thanks!

graingert · 2019-07-03T11:08:35Z

@nicoddemus this should also apply to pytest.warns

Co-Authored-By: Bruno Oliveira <nicoddemus@gmail.com>

graingert · 2019-07-03T11:13:57Z

@nicoddemus eg aliases for all these:

https://github.com/python/cpython/blob/3.7/Lib/unittest/case.py#L248-L261

nicoddemus · 2019-07-03T11:58:04Z

@nicoddemus eg aliases for all these:

Not sure if all of those, but warning <=> expected_warning I think so. 👍

nicoddemus · 2019-07-04T13:40:54Z

@graingert still want to add the aliases for pytest.warns?

graingert · 2019-07-04T14:40:47Z

looking at it now

graingert · 2019-07-04T14:57:31Z

@nicoddemus it's actually a bit of a pain as it would involve chainging how WarningsChecker works, eg it doesn't actually store the first matching warning anywhere

graingert · 2019-07-04T15:08:46Z

@nicoddemus looks a bit like graingert@4a2ced9

nicoddemus · 2019-07-04T21:55:29Z

I see. Well I think that's fine if indeed we want to add those aliases. 👍

nicoddemus

Thanks @graingert for the follow up! Please take a look at my comments when you have the chance. 👍

nicoddemus · 2019-07-05T22:09:12Z

src/_pytest/recwarn.py

@@ -186,28 +186,33 @@ def __exit__(self, *exc_info):
        __tracebackhide__ = True

        # only check if we're not currently handling an exception


We need a test for the warning attribute to avoid regressions.

nicoddemus · 2019-07-05T22:09:45Z

changelog/5541.feature.rst

@@ -0,0 +1 @@
+Add ``.exception`` attribute as an alias for ``.value`` to facilitate porting tests written using unittest.


This should be updated to mention the warning attribute of pytest.warns

Oh this should also be 5541.improvement.rst now.

nicoddemus · 2019-07-05T22:10:42Z

src/_pytest/recwarn.py

+            if issubclass(r.category, self.expected_warning) and (
+                self.match_expr is None or re.search(self.match_expr, str(r.message))
+            ):
+                self.warning = r.message


These attributes should be initialized with None in __init__

Also, we should add a quick example to the docs to warnings.rst. 👍

blueyed · 2019-11-05T23:40:19Z

@graingert gentle ping

graingert · 2019-11-05T23:42:07Z

Looks like this needs a rebase etc

nicoddemus · 2019-11-06T19:47:13Z

Looks like this needs a rebase etc

Indeed, also please see my comments. 👍

blueyed · 2020-01-25T10:08:06Z

src/_pytest/_code/code.py

+    @property
+    def exception(self):
+        """
+        an alias to '.value' to facilitate porting porting tests written using


Suggested change

an alias to '.value' to facilitate porting porting tests written using

an alias to '.value' to facilitate porting tests written using

nicoddemus · 2020-02-14T01:17:40Z

TBH I'm not sure this is worthwhile doing anymore... perhaps it is better to improve unittest2pytest to deal with this automatically, and mention it more prominently in the docs?

bluetech · 2020-02-16T15:15:49Z

We've recently stopped using the features branch

(I've changed the base on my own now).

bluetech · 2020-05-26T09:24:06Z

I agree with @nicoddemus; let's close this.

graingert mentioned this pull request Jul 3, 2019

assertRaises with context should replace context.exception with context.value pytest-dev/unittest2pytest#36

Open

nicoddemus requested changes Jul 3, 2019

View reviewed changes

src/_pytest/_code/code.py Outdated Show resolved Hide resolved

graingert changed the base branch from master to features July 3, 2019 10:52

graingert force-pushed the patch-2 branch 2 times, most recently from cfa1cf3 to 127de96 Compare July 3, 2019 10:56

Add exception to value alias on ExceptionInfo

1ebc8f9

For easier compatibility with unittest pytest-dev/unittest2pytest#36 Co-Authored-By: Bruno Oliveira <nicoddemus@gmail.com>

graingert force-pushed the patch-2 branch from 127de96 to 1ebc8f9 Compare July 3, 2019 10:58

nicoddemus reviewed Jul 3, 2019

View reviewed changes

changelog/5541.feature.rst Outdated Show resolved Hide resolved

nicoddemus approved these changes Jul 3, 2019

View reviewed changes

Update changelog/5541.feature.rst

bcb72ab

Co-Authored-By: Bruno Oliveira <nicoddemus@gmail.com>

add unittest compat attrs to recwarn

4a2ced9

nicoddemus requested changes Jul 5, 2019

View reviewed changes

pytest-dev deleted a comment from codecov bot Nov 5, 2019

blueyed reviewed Jan 25, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

bluetech changed the base branch from features to master February 16, 2020 15:14

bluetech closed this May 26, 2020

graingert deleted the patch-2 branch August 1, 2022 01:19

		@@ -186,28 +186,33 @@ def __exit__(self, *exc_info):
		__tracebackhide__ = True

		# only check if we're not currently handling an exception

		@@ -0,0 +1 @@
		Add ``.exception`` attribute as an alias for ``.value`` to facilitate porting tests written using unittest.

	an alias to '.value' to facilitate porting porting tests written using
	an alias to '.value' to facilitate porting tests written using

Uh oh!

Conversation

graingert commented Jul 3, 2019 • edited by blueyed Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RonnyPfannschmidt commented Jul 3, 2019

Uh oh!

graingert commented Jul 3, 2019

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

graingert commented Jul 3, 2019

Uh oh!

graingert commented Jul 3, 2019

Uh oh!

nicoddemus commented Jul 3, 2019

Uh oh!

nicoddemus commented Jul 4, 2019

Uh oh!

graingert commented Jul 4, 2019

Uh oh!

graingert commented Jul 4, 2019

Uh oh!

graingert commented Jul 4, 2019

Uh oh!

nicoddemus commented Jul 4, 2019

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

nicoddemus Jul 5, 2019

Choose a reason for hiding this comment

Uh oh!

nicoddemus Jul 5, 2019

Choose a reason for hiding this comment

Uh oh!

nicoddemus Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

nicoddemus Jul 5, 2019

Choose a reason for hiding this comment

Uh oh!

nicoddemus Jul 5, 2019

Choose a reason for hiding this comment

Uh oh!

blueyed commented Nov 5, 2019

Uh oh!

graingert commented Nov 5, 2019

Uh oh!

nicoddemus commented Nov 6, 2019

Uh oh!

blueyed Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

nicoddemus commented Feb 14, 2020

Uh oh!

bluetech commented Feb 16, 2020

Uh oh!

bluetech commented May 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

graingert commented Jul 3, 2019 •

edited by blueyed

Loading