Handle xfail(strict=True) properly in --step-wise mode#5555
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Jul 4, 2019
Merged
Handle xfail(strict=True) properly in --step-wise mode#5555nicoddemus merged 1 commit intopytest-dev:masterfrom
nicoddemus merged 1 commit intopytest-dev:masterfrom
Conversation
asottile
added
the
needs backport
Codecov Report
@@ Coverage Diff @@
## master #5555 +/- ##
==========================================
- Coverage 96.11% 96.09% -0.03%
==========================================
Files 117 117
Lines 25701 25713 +12
Branches 2493 2493
==========================================
+ Hits 24702 24708 +6
- Misses 695 701 +6
Partials 304 304
Continue to review full report at Codecov.
|
nicoddemus
commented
Jul 4, 2019
|
|
||
| # because we are writing to the same file, mtime might not be affected enough to | ||
| # invalidate the cache, making this next run flaky | ||
| testdir.tmpdir.join("__pycache__").remove() |
Member
Author
There was a problem hiding this comment.
argh!
Should we remove all __pycache__ directories from testdir.tmpdir before each testdir.runpytest call?
Member
There was a problem hiding this comment.
ufff that's pretty unfortunate. Probably not though, the assert rewrite tests I think need that
Another idea would be to use utime to force the issue in another way
Member
Author
There was a problem hiding this comment.
Well in that case it doesn't really matter, so let's stick with just removing the __pycache__ for now.
Member
Author
|
I'll handle the backport 👍 |
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jul 4, 2019
Handle xfail(strict=True) properly in --step-wise mode
nicoddemus
added
backported
and removed
needs backport
Member
|
grats on quads |
Member
Author
|
🎉 |
nicoddemus
added a commit
that referenced
this pull request
Jul 5, 2019
[4.6] Handle xfail(strict=True) properly in --step-wise mode (#5555)
graingert
reviewed
Jul 5, 2019
| @@ -72,7 +72,7 @@ def pytest_collection_modifyitems(self, session, config, items): | |||
|
|
|||
| def pytest_runtest_logreport(self, report): | |||
| # Skip this hook if plugin is not active or the test is xfailed. | |||
nicoddemus
pushed a commit
to nicoddemus/pytest
that referenced
this pull request
Jul 5, 2019
nicoddemus
added a commit
that referenced
this pull request
Jul 5, 2019
Fix comment in stepwise (follow up to #5555) [skip ci]
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jul 5, 2019
…est-dev#5560) Fix comment in stepwise (follow up to pytest-dev#5555) [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5547