Do not treat warnings as errors during pytest_configure.#5729
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Aug 15, 2019
Stranger6667:issue-5115
Merged
Do not treat warnings as errors during pytest_configure.#5729nicoddemus merged 1 commit intopytest-dev:masterfrom Stranger6667:issue-5115
pytest_configure.#5729nicoddemus merged 1 commit intopytest-dev:masterfrom
Stranger6667:issue-5115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5729 +/- ##
==========================================
+ Coverage 96.16% 96.17% +<.01%
==========================================
Files 117 117
Lines 25865 25873 +8
Branches 2498 2498
==========================================
+ Hits 24874 24884 +10
+ Misses 690 689 -1
+ Partials 301 300 -1
Continue to review full report at Codecov.
|
blueyed
reviewed
Aug 12, 2019
Contributor
blueyed
left a comment
blueyed
left a comment
There was a problem hiding this comment.
Not sure how to validate that the warning is emitted, tho :(
Contributor
Author
|
Thank you very much, Daniel! :) |
nicoddemus
reviewed
Aug 15, 2019
Member
|
@Stranger6667 hope you don't mind, I went ahead and squashed this myself given that you had agreed to squash before merging. 👍 |
Contributor
Author
|
Yes, sure, thank you @nicoddemus :) |
Contributor
|
@Stranger6667 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before it led to an internal error
Ref: #5115
Not sure how to validate that the warning is emitted, tho :(