assertrepr_compare: prefer same maxsize#5731
Merged
blueyed merged 1 commit intopytest-dev:featuresfrom Aug 12, 2019
Merged
Conversation
Previously it would say:
> assert '123456789012...901234567890A' == '1234567890123...901234567890B'"
This makes it look like the "3" might be different already.
This is clearer, and it is OK to have potentially one less char in the
right one:
> assert '123456789012...901234567890A' == '123456789012...901234567890B'"
Codecov Report
@@ Coverage Diff @@
## features #5731 +/- ##
============================================
- Coverage 96.25% 96.25% -0.01%
============================================
Files 117 117
Lines 25895 25899 +4
Branches 2494 2494
============================================
+ Hits 24926 24929 +3
- Misses 666 667 +1
Partials 303 303
Continue to review full report at Codecov.
|
nicoddemus
approved these changes
Aug 12, 2019
Member
|
We could use a |
Contributor
Author
I don't think so. But in general, what do you think about having a way to also look at commit messages when generating the changelog? |
Member
|
Not sure, we would need to see if it would be worth it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it would say:
This makes it look like the "3" might be different already.
This is clearer, and it is OK to have potentially one less char in the
right one: