assertion.rewrite: use ast.NameConstant(None) directly#5732
Merged
bluetech merged 1 commit intopytest-dev:featuresfrom Aug 12, 2019
Merged
assertion.rewrite: use ast.NameConstant(None) directly#5732bluetech merged 1 commit intopytest-dev:featuresfrom
bluetech merged 1 commit intopytest-dev:featuresfrom
Conversation
`ast.parse("None")` was added/used in 3e6f1fa for differences between
Python 2/3, but we do not support py2 anymore.
Codecov Report
@@ Coverage Diff @@
## features #5732 +/- ##
============================================
+ Coverage 96.25% 96.27% +0.01%
============================================
Files 117 117
Lines 25895 25896 +1
Branches 2494 2494
============================================
+ Hits 24926 24931 +5
+ Misses 666 663 -3
+ Partials 303 302 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
Thanks for the review!
Not sure either, but thought that this gets called/used a lot after all. |
Member
|
This seems trivial enough for me to merge, so I did. Also to avoid conflict when rebasing the above mentioned PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ast.parse("None")was added/used in 3e6f1fa for differences betweenPython 2/3, but we do not support py2 anymore.