2/X Fix check_untyped_defs = True mypy errors#5847
2/X Fix check_untyped_defs = True mypy errors#5847bluetech merged 7 commits intopytest-dev:featuresfrom
Conversation
9f60955 to
e399e72
Compare
|
The CI failed two times with coming from pytest/scripts/report-coverage.sh Line 16 in c8cf748 I don't think it is related to the changes. |
0df3898 to
37e0b7a
Compare
37e0b7a to
6715759
Compare
|
Note that mypy 0.740 substantially improved Could you check how things look with pytest and whether you're still willing to invest the effort to get it clean of errors? |
6715759 to
c1fb774
Compare
I tried 0.740 on pytest now -- it adds a dozen unrelated errors, and only a few new
Sure. I am trying to keep the PRs reasonably small, and only have one in-flight PR at a time, to not overwhelm anyone. However, there doesn't seem to be any volunteers to review these changes (understandably), so it's going to take a while. BTW, I rebased this PR now. |
In order to make the LiteralOutputChecker lazy initialization more amenable to type checking, I changed it to match the scheme already used in this file to lazy-initialize PytestDoctestRunner.
c1fb774 to
1787bff
Compare
Fixes for some more
check_untyped_defserrors from mypy.The first commit required a small refactoring (see commit message).
Continuation of #5673.