Add test to ensure _pytest is warning-clean on import#5904
Merged
asottile merged 1 commit intopytest-dev:masterfrom Oct 7, 2019
asottile:warnings_v2
Merged
Add test to ensure _pytest is warning-clean on import#5904asottile merged 1 commit intopytest-dev:masterfrom asottile:warnings_v2
asottile merged 1 commit intopytest-dev:masterfrom
asottile:warnings_v2
Conversation
Member
Author
|
from a timing perspective, this test is less worse than I expected: $ pytest testing/test_meta.py
============================= test session starts ==============================
platform linux -- Python 3.6.8, pytest-5.2.1.dev5+g9a4c0b991, py-1.8.0, pluggy-0.13.0
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/tmp/x/pytest/.hypothesis/examples')
rootdir: /tmp/x/pytest, inifile: tox.ini
plugins: hypothesis-4.38.1
collected 55 items
testing/test_meta.py ................................................... [ 92%]
.... [100%]
============================== 55 passed in 6.04s ============================== |
nicoddemus
approved these changes
Oct 6, 2019
Member
nicoddemus
left a comment
There was a problem hiding this comment.
Can you please rebase so we can get a green CI before merging? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #4510