[WIP][RFC][NOMERGE] Node nomore smart init#5935
Closed
RonnyPfannschmidt wants to merge 2 commits intopytest-dev:featuresfrom
Closed
[WIP][RFC][NOMERGE] Node nomore smart init#5935RonnyPfannschmidt wants to merge 2 commits intopytest-dev:featuresfrom
RonnyPfannschmidt wants to merge 2 commits intopytest-dev:featuresfrom
Conversation
this currently breaks fixture lookup as it now has to deal with types differently
… the dependencies
RonnyPfannschmidt
changed the title
Member
Author
|
i currently suspect that i cant make removing instance feasible without removing nodeid splitting and introducing per directory nodes which connect conftests to direct nodes |
Member
Author
|
leaving this sit for feedback and cringing |
Contributor
|
Nice, reminded me of #4357 - cannot provide much more help currently though. |
Member
Author
|
im canceling this one again as well, i will have to do a small series of breaking changes to get this sorted, this mess is just too interconnected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in this pr i experiment with breaking changes to node structure in order to get rid of the construction patterns that make things hard
as a starting point i removed instance, however so far that just broke fixture finding