summary/OutcomeException: add support for short_msg

[blueyed]

This is meant to improve the short msg with -r, where you want to see
the non-matched line, and not the first line (that might have matched),
from pytester's _match_lines.

This also improves __str__ / __repr__.

TODO:

• use it for doctests (ReprFailDoctest,

  pytest/src/_pytest/doctest.py

  Lines 229 to 280 in 5e7b2ae

  	def repr_failure(self, excinfo):
  	import doctest
  	failures = None
  	if excinfo.errisinstance((doctest.DocTestFailure, doctest.UnexpectedException)):
  	failures = [excinfo.value]
  	elif excinfo.errisinstance(MultipleDoctestFailures):
  	failures = excinfo.value.failures
  	if failures is not None:
  	reprlocation_lines = []
  	for failure in failures:
  	example = failure.example
  	test = failure.test
  	filename = test.filename
  	if test.lineno is None:
  	lineno = None
  	else:
  	lineno = test.lineno + example.lineno + 1
  	message = type(failure).__name__
  	reprlocation = ReprFileLocation(filename, lineno, message)
  	checker = _get_checker()
  	report_choice = _get_report_choice(
  	self.config.getoption("doctestreport")
  	)
  	if lineno is not None:
  	lines = failure.test.docstring.splitlines(False)
  	# add line numbers to the left of the error message
  	lines = [
  	"%03d %s" % (i + test.lineno + 1, x)
  	for (i, x) in enumerate(lines)
  	]
  	# trim docstring error lines to 10
  	lines = lines[max(example.lineno - 9, 0) : example.lineno + 1]
  	else:
  	lines = [
  	"EXAMPLE LOCATION UNKNOWN, not showing all tests of that example"
  	]
  	indent = ">>>"
  	for line in example.source.splitlines():
  	lines.append("??? {} {}".format(indent, line))
  	indent = "..."
  	if isinstance(failure, doctest.DocTestFailure):
  	lines += checker.output_difference(
  	example, failure.got, report_choice
  	).split("\n")
  	else:
  	inner_excinfo = ExceptionInfo(failure.exc_info)
  	lines += ["UNEXPECTED EXCEPTION: %s" % repr(inner_excinfo.value)]
  	lines += traceback.format_exception(*failure.exc_info)
  	reprlocation_lines.append((reprlocation, lines))
  	return ReprFailDoctest(reprlocation_lines)

  ) - not really sure what though - but might be just as simple as "doctest failed" - currently it is empty, see test_doctest_id.

[nicoddemus]

Great work!

I left some minor suggestions which I belive are simple and worth doing. 👍

[nicoddemus]

👍

[blueyed]

Incorporated feedback.

[blueyed]

Updated in blueyed#44.
Closing for now, might come back to it later.