Skip to content

tests: harden/fix test_trial_error #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blueyed merged 1 commit into from
Oct 20, 2019
Merged

tests: harden/fix test_trial_error #6005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions testing/test_unittest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def tearDownClass(self):
def test_method_and_teardown_failing_reporting(testdir):
testdir.makepyfile(
"""
import unittest, pytest
import unittest
class TC(unittest.TestCase):
def tearDown(self):
assert 0, "down1"
Expand Down Expand Up @@ -530,19 +530,31 @@ def f(_):
# will crash both at test time and at teardown
"""
)
result = testdir.runpytest()
# Ignore DeprecationWarning (for `cmp`) from attrs through twisted,
# for stable test results.
result = testdir.runpytest(
"-vv", "-oconsole_output_style=classic", "-W", "ignore::DeprecationWarning"
)
result.stdout.fnmatch_lines(
[
"test_trial_error.py::TC::test_four FAILED",
"test_trial_error.py::TC::test_four ERROR",
"test_trial_error.py::TC::test_one FAILED",
"test_trial_error.py::TC::test_three FAILED",
"test_trial_error.py::TC::test_two FAILED",
"*ERRORS*",
"*_ ERROR at teardown of TC.test_four _*",
"*DelayedCalls*",
"*test_four*",
"*= FAILURES =*",
"*_ TC.test_four _*",
"*NameError*crash*",
"*test_one*",
"*_ TC.test_one _*",
"*NameError*crash*",
"*test_three*",
"*_ TC.test_three _*",
"*DelayedCalls*",
"*test_two*",
"*crash*",
"*_ TC.test_two _*",
"*NameError*crash*",
"*= 4 failed, 1 error in *",
]
)

Expand Down