addini: allow for default=None, use notset sentinel#6118
Closed
blueyed wants to merge 1 commit intopytest-dev:featuresfrom
Closed
addini: allow for default=None, use notset sentinel#6118blueyed wants to merge 1 commit intopytest-dev:featuresfrom
blueyed wants to merge 1 commit intopytest-dev:featuresfrom
Conversation
Contributor
Author
|
As per #6117 this might change behavior, closing for now. |
4 tasks
Member
|
TBH I think we should reopen and go for this in the next minor release... I don't think it will cause too much breakage, and the new behavior is much more sane and seems to me is fixing an annoying wart that was included as an oversight. If people are really concerned, I still would like to see this in 6.0 at least, but I'm not sure how to properly warn on this given that the problem is the return value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6117.