Removing variable being reassigned#6134
Merged
The-Compiler merged 1 commit intopytest-dev:masterfrom Nov 5, 2019
Merged
Conversation
Contributor
Author
|
Why did that codecov fail. Must be cause I removed a line of code?? |
The-Compiler
approved these changes
Nov 5, 2019
Member
Member
|
hmm yeah automated tooling sometimes exposes the nonsense that was already there 😆 (this used to be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off thank you for providing great open source pytest. Wanted to make a small bug fix. I see your reassigning a variable
explanation = explanationthen using it below that. Didn't make logically sense. So I thought would be nice to send a bug fix.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features, improvements, and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order;