Preparing release version 5.2.4

[asottile]

No description provided.

[blueyed]

Seems like this list is off? (nitpick, not relevant here)

[asottile]

yeah no idea how towncrier computes this -- perhaps it includes reporters of associated issues?

[nicoddemus]

It is actually computed by release.py:

pytest/scripts/release.py

Lines 16 to 26 in 19a15a9

	# Get our list of authors
	stdout = check_output(["git", "describe", "--abbrev=0", "--tags"])
	stdout = stdout.decode("utf-8")
	last_version = stdout.strip()
	stdout = check_output(
	["git", "log", "{}..HEAD".format(last_version), "--format=%aN"]
	)
	stdout = stdout.decode("utf-8")
	contributors = set(stdout.splitlines())

@asottile please make sure you have the tags locally.

[asottile]

I do have them -- here's what it reports:

$ git describe --abbrev=0 --tags
5.2.3
$ git log 5.2.3..HEAD --format=%aN
Anthony Sottile
Anthony Sottile
Anthony Sottile
Anthony Sottile
Bruno Oliveira
Daniel Hahler
Bruno Oliveira
Michael Shields
Hugo
Hugo

which is weird given:

$ git log --graph --oneline --decorate
* c9a96cdee (HEAD -> release-5.2.4, asottile/release-5.2.4) Preparing release version 5.2.4
*   19a15a94e (origin/master, origin/HEAD, master) Merge pull request #6197 from asottile/fix_init_py_discovery
|\  
| * 4e0f99260 (asottile/fix_init_py_discovery, fix_init_py_discovery) Add regression tests for __init__.py breakage
| * 176c7771f Revert "fix bug with nonskipped first test in package (#5831)"
|/  
*   e856638ba Preparing release version 5.2.3 (#6190)
|\  
| * dd9a27cf5 (tag: 5.2.3) Adjust CHANGELOG

[blueyed]

The new tag is 5.2.4.

[asottile]

yes, this command is "what has changed since the last tag"

[blueyed]

Ah.. that's because the tag is not on the master branch I think.