Fix --setup-plan fixture lifetimes#6214
Merged
nicoddemus merged 4 commits intopytest-dev:masterfrom Nov 18, 2019
JoshKarpel:fix-setup-plan
Merged
Fix --setup-plan fixture lifetimes#6214nicoddemus merged 4 commits intopytest-dev:masterfrom JoshKarpel:fix-setup-plan
nicoddemus merged 4 commits intopytest-dev:masterfrom
JoshKarpel:fix-setup-plan
Conversation
nicoddemus
approved these changes
Nov 18, 2019
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks a lot @JoshKarpel! Excellent PR: clean code, very well documented, well written tests. Awesome!
Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2049 by setting the
fixturedefcache key in the dummy fixture result used when--setup-planruns (the current implementation does not). This makes the printing of theSETUP/TEARDOWNmessages obey the fixture lifetimes as expected (and as already correctly happens with--setup-show).I added two tests, but they're both rather crude. One just sets up a simple class-scoped fixture and checks that the correct number of messages appear. The other checks that the printed output of
--setup-showand--setup-planagree on the ordering and number of messages. I don't know if there any good idioms for this kind of thing in the test suite already. Happy to make changes if they're not up to snuff!