Skip to content

docs: configure default_role=literal#6248

Merged
blueyed merged 1 commit intopytest-dev:masterfrom
blueyed:default-role
Nov 21, 2019
Merged

docs: configure default_role=literal#6248
blueyed merged 1 commit intopytest-dev:masterfrom
blueyed:default-role

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 20, 2019

This configures the default role for interpreted text (single
backticks), avoiding the need to check for / enforce double backticks.

Fixes also one instance in the existing changelog:

- Detect `pytest_` prefixed hooks using the internal plugin manager since
  ``pluggy`` is deprecating the ``implprefix`` argument to ``PluginManager``.
  (`#3487 <https://github.com/pytest-dev/pytest/issues/3487>`_)

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh cool, good find! This should go into master though so we can benefit from it right away.

This configures the default role for interpreted text (single
backticks), avoiding the need to check for / enforce double backticks.

Fixes also one instance in the existing changelog:

    - Detect `pytest_` prefixed hooks using the internal plugin manager since
      ``pluggy`` is deprecating the ``implprefix`` argument to ``PluginManager``.
      (`pytest-dev#3487 <https://github.com/pytest-dev/pytest/issues/3487>`_)
@blueyed blueyed changed the base branch from features to master November 20, 2019 23:35
@blueyed blueyed requested a review from nicoddemus November 21, 2019 02:07
@blueyed blueyed merged commit 8b7aeef into pytest-dev:master Nov 21, 2019
@blueyed blueyed deleted the default-role branch November 21, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants