Add develop instructions to CONTRIBUTING#6249
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Nov 21, 2019
Merged
Conversation
nicoddemus
force-pushed
the
devel-install
branch
from
325713f to
b2951e4
Compare
Member
Author
|
Cool, thanks for the review. 👍 |
bluetech
approved these changes
Nov 21, 2019
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
LGTM.
If we recommend .venv/, it will be good to add it to .gitignore.
Member
Author
Yeah, now that you mention, that's why my gut feeling was using But no worries, added |
nicoddemus
force-pushed
the
devel-install
branch
from
b2951e4 to
8f2fd8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: #6244