Add GitHub actions for CI#6355
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Dec 26, 2019
Merged
Conversation
samueljsb
approved these changes
Dec 19, 2019
Contributor
samueljsb
left a comment
samueljsb
left a comment
There was a problem hiding this comment.
Looks good to me!
Is it worth adding MacOS for python 3.8 while you're here?
This includes our current full matrix (windows, linux and macos), for evaluting purposes. We should disconsider failures when evaluating PRs. TODO: - deploy - coverage - github release notes Even with the above missing, I still believe it would be nice to merge this and have GitHub actions working in parallel so we can evaluate performance and usability from now on.
nicoddemus
force-pushed
the
add-gh-actions
branch
from
0191ae5 to
d76aa8b
Compare
Member
Author
Done! It is now building, hopefully MacOS Python 3.8 will also pass. 🤞 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes our current full matrix (windows, linux and macos), for evaluting
purposes.
We should disconsider failures when evaluating PRs.
TODO:
Even with the above missing, I still believe it would be nice to merge
this and have GitHub actions working in parallel so we can evaluate performance
and usability from now on.
Unfortunately due to the way GitHub actions work, the jobs are not triggered until GitHub actions are enabled on
master, but the results of this build can be seen here:nicoddemus#11