pytester: typing for spawn/spawn_pytest#6434
Merged
blueyed merged 1 commit intopytest-dev:masterfrom Jan 17, 2020
Merged
Conversation
spawn/spawn_pytestspawn/spawn_pytest
bluetech
approved these changes
Jan 12, 2020
Member
bluetech
left a comment
There was a problem hiding this comment.
LGTM.
BTW, the code in spawn_pytest is pretty scary 😨 , in that it looks open to shell-injection. It would be better to use the args format instead of joining the arguments to a string. That's not related to this PR though, and maybe the input is always good - I didn't check.
invoke = " ".join(map(str, self._getpytestargs()))
cmd = "{} --basetemp={} {}".format(invoke, basetemp, string)
return self.spawn(cmd, expect_timeout=expect_timeout)
Contributor
Author
|
Yeah, I've made it using I'll rebase this after #6435. |
spawn/spawn_pytestspawn/spawn_pytest
98665f0 to
3694415
Compare
Contributor
Author
|
Rebased on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting on davidhalter/jedi#1472.Blocked by #6435.