Merge master into features#6458
Merged
nicoddemus merged 15 commits intopytest-dev:featuresfrom Jan 14, 2020
Merged
Conversation
This overwrites the `codecov.yml` file in the root of the repository with `codecov-upstream.yml` file (which contains the code-cov token)´, so PRs and branches on the repository can upload coverage. Suggestion from here: pytest-dev#6421 (comment) Security concerns: the token might be misused, but only to upload bogus coverage to `codecov.io`, so the team believe this is harmless. If we decide to fallback from this decision , we just need to revoke the token. Related to pytest-dev#6369
tox: linting: pass posargs
typing: fix _pytest.config.findpaths.determine_setup
master: update mypy 0.740 -> 0.761
Python 3.5.0 caused flaky failures before (pytest-dev#5795). This is pulled out of pytest-dev#6435, which adds code specific for Python < 3.5.2. It only runs a specific test, while collecting everything to get coverage of the version specific code around typing.
ci: Travis: Python 3.5.1 via Trusty
Implement code coverage in GitHub actions
blueyed
approved these changes
Jan 14, 2020
Member
Author
|
Trying a workaround for py35-win in 04d5b56 |
Member
Author
|
Disabling cov entirely on py35-win to make sure it is coverage related |
Member
Author
|
Oh OK, it is not coverage related then: |
2 tasks
Contributor
|
I'd say to a) skip the test there, or b) use the simplified/mocked version (without multiprocessing). |
Member
Author
Yeah that is what I was thinking, I will get to this later. |
Somehow in Python 3.5 on Windows this test fails with:
File "c:\hostedtoolcache\windows\python\3.5.4\x64\Lib\multiprocessing\connection.py", line 302, in _recv_bytes
overlapped=True)
OSError: [WinError 6] The handle is invalid
This only happens in this platform and Python version, decided to use
a dummy traceback as originally done in pytest-dev#6412.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #6457