Merged
Conversation
RonnyPfannschmidt
approved these changes
Jan 15, 2020
| assert safe_getattr(helper, "raise_exception", "default") == "default" | ||
| assert safe_getattr(helper, "raise_fail", "default") == "default" | ||
| with pytest.raises(BaseException): | ||
| assert safe_getattr(helper, "raise_baseexception", "default") |
Member
There was a problem hiding this comment.
good find, i recall that we have outcome exception handling - if that's the case can you cover that as well?
Contributor
Author
There was a problem hiding this comment.
Not sure what you mean.
I've noticed that it's not covered with 85a813b#diff-4ec37b1ad5b7d41fdac56c907d08dde1R335-R340 (reverted there, but still).
Contributor
Author
There was a problem hiding this comment.
"outcome exception" is raise_fail there (https://github.com/pytest-dev/pytest/pull/6466/files#diff-ad34b016af6f6485ba6c85afe4d9464cR159).
Member
There was a problem hiding this comment.
indeed, i missed that bit, thanks for calling out
i think i would have noted it better if it was named raise_fail_outcome, what do you think about the naming
blueyed
force-pushed
the
cover-safe_getattr
branch
from
5b3b02b to
6f7a95c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via #6435.