tests: cover absolute path handling in _compute_fixture_value

[blueyed]

No description provided.

[nicoddemus]

Thanks!

Please rebase/add a descriptive commit message.

[blueyed]

@nicoddemus

Please rebase/add a descriptive commit message.

Not sure what you mean.. do you mean it should be squashed?
I've done it in 2 commits, since the 2nd is a partial cherry-pick, and AFAICS the commit messages are fine?

[nicoddemus]

Not sure what you mean.. do you mean it should be squashed?

Oops sorry, yes.

I've done it in 2 commits, since the 2nd is a partial cherry-pick, and AFAICS the commit messages are fine?

The commit messages don't really explain the context of the changes, for example the first one is just "source_path: py.path.local directly", which explains what it is doing, but not "why". I always try to think of the POV of someone who needs to look at the history a few years down the road and needs to figure out why things are they way they are.

But if they do look fine to you, please go ahead and merge. And thanks for the coverage improvement. 👍

[blueyed]

"source_path: py.path.local directly" could be "Assign source_path via py.path.local directly", but should really be clear from the change itself (7c87874). The reference there is where it is taken from (in features), and keeping it separate helps with conflicts when rebasing/merging.
Thanks for the suggestion / review though.. 👍