Fix node ids which contain a parametrized empty-string variable#6607
Merged
asottile merged 1 commit intopytest-dev:featuresfrom Jan 29, 2020
asottile:empty_string_parametrize_nodeid
Merged
Fix node ids which contain a parametrized empty-string variable#6607asottile merged 1 commit intopytest-dev:featuresfrom asottile:empty_string_parametrize_nodeid
asottile merged 1 commit intopytest-dev:featuresfrom
asottile:empty_string_parametrize_nodeid
Conversation
Contributor
|
LGTM, but typically it is called "nodeids". |
RonnyPfannschmidt
approved these changes
Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went with
featuresas this changes the node ids -- I could target master instead if this is desirable as a bugfix.partially fixes #6597