tests: move test_getfslineno#6610
Merged
blueyed merged 2 commits intopytest-dev:masterfrom Jan 29, 2020
Merged
Conversation
It should be in `test_code` when testing `_pytest._code.getfslineno`, not to be confused with `_pytest._code.source.getfslineno`. Adds an extra assert (via pytest-dev#6590).
blueyed
force-pushed
the
tests-move-test_getfslineno
branch
from
fea51f5 to
a3f482c
Compare
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 29, 2020
Reverts pytest-dev#6610. The tested `getfslineno` is `src/_pytest/_code/source.py` actually, exported via `src/_pytest/_code/__init__.py`. I've confused it with the one in `src/_pytest/compat.py` apparently.
Contributor
Author
|
Got it wrong.. followup: #6623 |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 29, 2020
Reverts pytest-dev#6610. The tested `getfslineno` is `src/_pytest/_code/source.py` actually, exported via `src/_pytest/_code/__init__.py`. I've confused it with the one in `src/_pytest/compat.py` apparently.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 29, 2020
Reverts pytest-dev#6610. The tested `getfslineno` is `src/_pytest/_code/source.py` actually, exported via `src/_pytest/_code/__init__.py`. I've confused it with the one in `src/_pytest/compat.py` apparently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be in
test_codewhen testing_pytest._code.getfslineno,not to be confused with
_pytest._code.source.getfslineno.Adds an extra assert (via #6590).