Skip to content

Merge master to features - one last time#6640

Merged
bluetech merged 25 commits intopytest-dev:featuresfrom
bluetech:master-to-features
Jan 31, 2020
Merged

Merge master to features - one last time#6640
bluetech merged 25 commits intopytest-dev:featuresfrom
bluetech:master-to-features

Conversation

@bluetech
Copy link
Member

Part of #6571 transition plan. I am doing this merge so that the reverse merge (coming up shortly) is clean.

blueyed and others added 25 commits January 25, 2020 16:44
Makes `parent` a required arg, which would have failed before via
`parent.session` anyway.

Keeps calling/passing unused args for B/C.
Only copy'n'paste error from c416b1d.
Use --wrap=preserve in release notes script
Reword fixture docs for clarity
Not known with `curl` on Travis at least.

Reverts pytest-dev#6573.

This reverts commit df1f43e.
Revert "ci: codecov: use `--retry-connrefused` with curl"
This gets typically used always (via `getfixtureinfo`).
fixtures: move import of ParameterSet to top level
minor: doc: getfuncargnames: move TODO out of docstring
`-fE` is the default in `features` now [1], but the idea is to add `X`
also to it in the long run, so let's dogfood it ourselves.

1: pytest-dev#6524
2: pytest-dev#6524 (comment)
@bluetech bluetech changed the base branch from master to features January 31, 2020 09:35
@bluetech
Copy link
Member Author

Hmm I guess this needs to be approved, I didn't think of that 🤕 There were only trivial conflicts. To proceed with the other steps, if anyone sees this, please approve :)

@blueyed
Copy link
Contributor

blueyed commented Jan 31, 2020

Hmm I guess this needs to be approved, I didn't think of that There were only trivial conflicts.

Typically good to add them with the merge commit message (i.e. uncomment what git merge gives you).

To proceed with the other steps, if anyone sees this, please approve :)

I'm not sure if / how you want to proceed, but I'd like to at least you, @nicoddemus and @RonnyPfannschmidt to also approve that features should get merged into master as-is really (#6571 (comment)).

@bluetech
Copy link
Member Author

Thanks @blueyed, I think I will need to ping you for a few more steps...

@bluetech bluetech merged commit 4038d6c into pytest-dev:features Jan 31, 2020
@bluetech bluetech deleted the master-to-features branch January 31, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants