tests: check result with test_510 - test likely needs fixing#6813
Closed
blueyed wants to merge 1 commit intopytest-dev:masterfrom
Closed
tests: check result with test_510 - test likely needs fixing#6813blueyed wants to merge 1 commit intopytest-dev:masterfrom
test_510 - test likely needs fixing#6813blueyed wants to merge 1 commit intopytest-dev:masterfrom
Conversation
Note that the output changed with 9e26203, so the test should likely be fixed. Ref: pytest-dev#519 (- haven't looked into what the issue is about). Example script was added in c081c5e, changed in ea90605, currently outputs: Previous output: ``` ['============================= test session starts ==============================', 'platform linux -- Python 3.8.1, pytest-5.3.5.dev567+gfba7d992a.d20200224, py-1.8.2.dev3+g2b6bd292, pluggy-0.13.1', 'rootdir: ~', 'collected 8 items', '', 'issue_519.py ........E [100%]', '', '==================================== ERRORS ====================================', '_________________ ERROR at teardown of test_two[arg1v2-arg2v2] _________________', '', ' @pytest.fixture(scope="session")', ' def checked_order():', ' order = []', ' ', ' yield order', ' pprint.pprint(order)', '> assert order == [', ' ("testing/example_scripts/issue_519.py", "fix1", "arg1v1"),', ' ("test_one[arg1v1-arg2v1]", "fix2", "arg2v1"),', ' ("test_two[arg1v1-arg2v1]", "fix2", "arg2v1"),', ' ("test_one[arg1v1-arg2v2]", "fix2", "arg2v2"),', ' ("test_two[arg1v1-arg2v2]", "fix2", "arg2v2"),', ' ("testing/example_scripts/issue_519.py", "fix1", "arg1v2"),', ' ("test_one[arg1v2-arg2v1]", "fix2", "arg2v1"),', ' ("test_two[arg1v2-arg2v1]", "fix2", "arg2v1"),', ' ("test_one[arg1v2-arg2v2]", "fix2", "arg2v2"),', ' ("test_two[arg1v2-arg2v2]", "fix2", "arg2v2"),', ' ]', "E AssertionError: assert [('issue_519....arg1v2'), ...] == [('testing/ex...arg1v2'), ...]", 'E At index 0 diff:', "E ('issue_519.py', 'fix1', 'arg1v1') !=", "E ('testing/example_scripts/issue_519.py', 'fix1', 'arg1v1')", 'E Use -v to get the full diff', '', "issue_519.py:20: AssertionError: assert [('issue_519....arg1v2'), ...] == [('testing/ex...arg1v2'), ...]...", '--------------------------- Captured stdout teardown ---------------------------', "[('issue_519.py', 'fix1', 'arg1v1'),", " ('test_one[arg1v1-arg2v1]', 'fix2', 'arg2v1'),", " ('test_two[arg1v1-arg2v1]', 'fix2', 'arg2v1'),", " ('test_one[arg1v1-arg2v2]', 'fix2', 'arg2v2'),", " ('test_two[arg1v1-arg2v2]', 'fix2', 'arg2v2'),", " ('issue_519.py', 'fix1', 'arg1v2'),", " ('test_one[arg1v2-arg2v1]', 'fix2', 'arg2v1'),", " ('test_two[arg1v2-arg2v1]', 'fix2', 'arg2v1'),", " ('test_one[arg1v2-arg2v2]', 'fix2', 'arg2v2'),", " ('test_two[arg1v2-arg2v2]', 'fix2', 'arg2v2')]", ```
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Feb 24, 2020
Output is not being looked at, and it changed/broke recently apparently. Ref: pytest-dev#6813
This was referenced Feb 24, 2020
Contributor
Author
|
Turned into an issue, since I do not plan to work on this. |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Feb 24, 2020
Output is not being looked at, and it changed/broke recently apparently. Ref: pytest-dev#6813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the output changed with 9e26203 (#3623), so the test should likely
be fixed.
Ref: #519 (- haven't looked into what the issue is about).
Might also be #510 ? (mixed names)
Example script was added in c081c5e, changed in ea90605, currently outputs:
Previous output: