pre-commit: black: --target-version py35#6872
Merged
blueyed merged 2 commits intopytest-dev:masterfrom Mar 8, 2020
Merged
Conversation
This was referenced Mar 7, 2020
bluetech
approved these changes
Mar 7, 2020
nicoddemus
approved these changes
Mar 7, 2020
Contributor
Author
|
What about using a config instead?
|
Contributor
Author
|
I assume this will make it work better out of pre-commit also. But likely I was just being "tricked" by having added trailing commas myself, and then black does not remove them (I guess). |
Member
|
Config file would be better, this way editors will be able to catch it as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to avoid having trailing commas after
**kwargs, whichonly works in Python 3.5.2+.
Ref: 2e756d698, #5611
Might make more sense to add config for it: blueyed#275