7119: data loss with mistyped --basetemp#7170
Merged
nicoddemus merged 17 commits intopytest-dev:masterfrom Jun 9, 2020
primaprashant:bugfix-data-loss-with-basetemp
Merged
7119: data loss with mistyped --basetemp#7170nicoddemus merged 17 commits intopytest-dev:masterfrom primaprashant:bugfix-data-loss-with-basetemp
nicoddemus merged 17 commits intopytest-dev:masterfrom
primaprashant:bugfix-data-loss-with-basetemp
Conversation
bluetech
requested changes
May 6, 2020
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Thanks @prashant616! I left some comments.
nicoddemus
reviewed
May 6, 2020
nicoddemus
requested changes
May 6, 2020
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @prashant616 for tackling this!
nicoddemus
added
the
needs backport
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Co-authored-by: Ran Benita <ran@unusedvar.com>
Co-authored-by: Ran Benita <ran@unusedvar.com>
bluetech
approved these changes
May 10, 2020
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Great work @prashant616, LGTM with a minor suggestion to the changelog entry.
Co-authored-by: Ran Benita <ran@unusedvar.com>
bluetech
approved these changes
May 11, 2020
| raise argparse.ArgumentTypeError(msg) | ||
|
|
||
| # check symlinks for ancestors | ||
| if is_ancestor(Path.cwd().resolve(), Path(path).resolve()): |
Member
Member
|
@nicoddemus gentle ping, i believe this can go in with the caveat that the path check has to be crosschecked with the other pr |
nicoddemus
approved these changes
Jun 9, 2020
Member
|
Thanks a lot @prashant616, and sorry about the delay here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise exception if
basetempargument is empty string or . or parent folder of current working directory.Closes #7119