More type annotations, fix some typing bugs#7358
Merged
bluetech merged 6 commits intopytest-dev:masterfrom Jun 13, 2020
Merged
Conversation
Not needed since update from mypy 0.770 -> 0.780.
Also switch to using ExceptionRepr instead of `Union[ReprExceptionInfo, ExceptionChainRepr]` which is somewhat annoying and less future proof.
These errors are found using a typed version of py.path.local.
Fixes: src/_pytest/config/__init__.py:1071: error: Argument 1 to "Version" has incompatible type "Union[str, List[str]]"; expected "str" [arg-type]
Member
Author
Member
Member
|
Thanks @nicoddemus / @bluetech Im a bit busy for a day or two and then il revisit my other PR; this is likely merged by then and il bring it in. I need to revisit as to some information Ran has mentioned. |
Member
Sure thing, take your time. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the commits, but here's a summary:
MonkeyPatchpytest_keyboard_interruptandpytest_internalerrorhookspy.path.localpackaging