Skip to content

Conversation

@bluetech
Copy link
Member

@nicoddemus
Copy link
Member

Thanks!

While at it, would you mind taking care of this comment?

pytest/setup.py

Lines 3 to 4 in b322004

# TODO: if py gets upgrade to >=1.6,
# remove _width_of_current_line in terminal.py

(We lost it by accident it seems when moving settings to setup.cfg)

@nicoddemus
Copy link
Member

nicoddemus commented Jun 15, 2020

Also, I think it is worth adding a trivial CHANGELOG entry for this. 👍

@bluetech
Copy link
Member Author

@nicoddemus I added a changelog entry. The setup.cfg comment is actually no longer relevant ever since we imported TerminalWriter into pytest.

@bluetech bluetech merged commit 06489d2 into pytest-dev:master Jun 15, 2020
@nicoddemus
Copy link
Member

Ahh right, thanks! 👍

@bluetech bluetech deleted the py-182 branch June 17, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit sets/dicts of py.path.locals

3 participants