Reintroduce warnings postponed in 6.0#7637
Reintroduce warnings postponed in 6.0#7637nicoddemus merged 2 commits intopytest-dev:masterfrom mcsitter:7361-reintroduce-warnings-postponed
Conversation
There was a problem hiding this comment.
Thanks a lot @mcsitter for getting to this.
I've dug around the Git history to find the original deprecation messages for those entries, please see my comments. 👍
|
I don't understand our deprecation plans here - all deprecations are errors now, even new deprecations we're introducing? In other words, there is no phase where new deprecations are warnings rather than errors? |
Yeah I didn't mention, but one of the first things we should do is #5585 and turn back |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
After #7660 gets merged we can rebase this one. 👍 |
|
Will do! I never rebased a branch in a PR. I think I have to 1. pull from upstream master with the rebase flag. Once I learned to 2. deal with merge conflicts, I will 3. push the changes to my fork. I think a rebase can rewrite history, so i am trying to be careful. |
That's pretty much it, yes. Let us know if you run into trouble! Thanks!
You are right, a rebase normally rewrites history, but it is only on your fork so it is alright. 👍 |
|
Rebase done. Thank you for your support! Tests are also passing. This is really delightful 😄 |
|
Looks great! Thanks a lot @mcsitter! |
I came across the comment
# Uncomment this after 6.0 release (#7361). Here is my PR for this.Still working on the changelog text. In
deprecated.pythere are explanations for the deprecations already. Should I just copy them and shorten where it makes sense?closes #7361