Merged
Conversation
bluetech
reviewed
Oct 5, 2020
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Great, LGTM with some comments.
Member
Author
|
Thanks for the great review @bluetech (I should actually caught many of the problems myself before opening this). I will get back to this once I have some free time, next weekend at latest. 👍 |
New pytester fixture with same functionality as testdir, but dealing with pathlib.Path objects. Also: * Change Testdir to be a thin wrapper which only delegates to PyTester. * Convert test_doctest to use test_path and tmp_path. * Removed some str() calls now unnecessary given py35 support has been dropped. * Use test_path in test_no_brokenpipeerror_message: it uses a private method which I don't think we should expose in Testdir for now.
nicoddemus
force-pushed
the
new-pytester-fixture
branch
from
6963d00 to
a8b07ce
Compare
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
I absolutely love the overall pr, i wonder if we should provide a plugin with a reverse shim for older pytest / python versions to unblock people porting to the new api even if they are on old python/pytest
It might be a nice hacktober item for someone
src/_pytest/pytester.py
Outdated
|
|
||
| """ | ||
| import warnings | ||
| from _pytest.warning_types import PYTESTER_COPY_EXAMPLE |
bluetech
reviewed
Oct 11, 2020
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Left a few minor comments, in addition to a couple previous suggestions
Member
Author
|
Anything else @bluetech @RonnyPfannschmidt ? |
bluetech
approved these changes
Oct 12, 2020
RonnyPfannschmidt
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New pytester fixture with same functionality as testdir, but dealing
with pathlib.Path objects.
Also:
which I don't think we should expose in Testdir for now.
Replaces #7425.