address #8361 - introduce hook caller wrappers that enable backward compat#8463
Conversation
…backward compat
|
change makes sense, probably need a test or two to demonstrate the behaviour (do we want a warning and to eventually migrate?) |
RonnyPfannschmidt
changed the title
|
I also think this is a good approach to #8361. 👍 |
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Thanks for looking at this.
As I mentioned, I don't think we really need to do this, but if we can have a way to deprecate, I guess it's OK.
I think wrapping at the config.hook level is not sufficient -- some of the hooks use an FSHookProxy (gethookproxy) which uses the plugin manager directly. I think if possible it would be better to add this directly on the PytestPluginManager.
I'm also think this might have some non-negligible effect on performance but I didn't measure. Can do once it's further along.
| proxy = FSHookProxy(pm, remove_mods) | ||
| from .config.compat import PathAwareHookProxy | ||
|
|
||
| proxy = PathAwareHookProxy(FSHookProxy(pm, remove_mods)) |
|
@bluetech i believe, in a followup i can even add some bits to ensure the cost can be removed if people opt out of legacy paths |
RonnyPfannschmidt
changed the title
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Overall great work, please see my comments!
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
looks good! thanks for the good tests
4 participants
fixes #8361