Issue #8823 - remove bots from contributors list#8828
Issue #8823 - remove bots from contributors list#8828The-Compiler merged 4 commits intopytest-dev:mainfrom
Conversation
scripts/release.py
Outdated
| contributors = set(stdout.splitlines()) | ||
|
|
||
| # remove strings within contributors that have substring "[bot]" | ||
| for name in contributors: |
There was a problem hiding this comment.
| for name in contributors: | |
| for name in list(contributors): |
Otherwise we will change the size of the set during iteration and raise an error.
There was a problem hiding this comment.
But probably it is easier to update line 23 to:
contributors = set(x for x in stdout.splitlines() if "[bot]" not in x)There was a problem hiding this comment.
Yeah I agree. I think the one-liner works well and looks nicer. Should I make a new commit?
There was a problem hiding this comment.
We typically squash PRs into a single commit when merging, so feel free to just push a second commit to the same branch (which will automatically update the PR).
As an aside, I'd probably use name instead of x, and if not name.endswith("[bot]") as I think it's always used as a suffix.
for more information, see https://pre-commit.ci
The-Compiler
left a comment
The-Compiler
left a comment
There was a problem hiding this comment.
Looks great now, thanks! 🎉 One step closer to the 7.0 release!
3 participants
No description provided.