Show fullname on direct Node construction warning#9066
Merged
nicoddemus merged 2 commits intopytest-dev:mainfrom Oct 5, 2021
Merged
Show fullname on direct Node construction warning#9066nicoddemus merged 2 commits intopytest-dev:mainfrom
nicoddemus merged 2 commits intopytest-dev:mainfrom
Conversation
This commit add the fullname on the Node construction warning. Also add a test for this case.
nicoddemus
requested changes
Sep 2, 2021
Member
There was a problem hiding this comment.
This is great, thanks a lot @eamanu!
Couple of small things before we can merge:
-
Include a small changelog entry, in
changelog/8994.improvement.rst:Included the module of the class in the error message about direct node construction (without using ``from_parent``). -
Please add yourself to the
AUTHORSfile
Thanks!
Contributor
Author
|
Hello @nicoddemus, Thanks for the review. I added the changelog file. I'm already in AUTHORS file :-) |
Member
Ahh sorry, did not actually check. 😁 LGTM, thanks! |
nicoddemus
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit add the fullname on the Node construction warning.
Also add a test for this case.
closes #8994